Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release checklist following v2024.5.0 release #2675

Merged

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented May 8, 2024

I'm creating this PR so that we can update the release checklist that gets used when creating an issue for the the subsequent release. At this point, it'll probably only need a few minor clarifications. Thank you to @rocco8773 for pointing the need out!

  • Address this comment: I don't know where this goes, but I think the checklist needs to be updated with when to create the release branch. The second to last check in the "Perform the release" talks about creating and merging a PR, but never talks about when to create a branch, what to name the branch, etc. Maybe this happens in the "mint release" GA, but if that's the case then that line should specifically state you're doing that.
  • Address this comment: I have a similar comment issue with the "create a release on GitHub" check. Which branch do you create the release from? main or the release branch?

@github-actions github-actions bot added the GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.36%. Comparing base (5a8c3d5) to head (bd4dccd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
- Coverage   95.15%   94.36%   -0.80%     
==========================================
  Files         107      107              
  Lines        9458     9458              
  Branches     2184     2184              
==========================================
- Hits         9000     8925      -75     
- Misses        276      345      +69     
- Partials      182      188       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@namurphy namurphy marked this pull request as ready for review May 9, 2024 14:43
@namurphy namurphy added the status: ready for review PRs that are ready for code review label May 13, 2024
@namurphy namurphy requested a review from rocco8773 May 16, 2024 16:30
@namurphy namurphy requested a review from ejohnson-96 June 3, 2024 21:58
@namurphy namurphy merged commit ca8f46a into PlasmaPy:main Jun 21, 2024
16 of 17 checks passed
@namurphy namurphy deleted the update-release-checklist-post-2024.5.0 branch June 21, 2024 19:55
@github-actions github-actions bot removed status: ready for review PRs that are ready for code review no changelog entry needed labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant