Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K a notebook #2196

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

K a notebook #2196

wants to merge 16 commits into from

Conversation

ejohnson-96
Copy link
Contributor

Description

Adding the kinetic alfven notebook, ignore prior PR for this.

Motivation and context

Related issues

@ejohnson-96 ejohnson-96 requested a review from a team as a code owner June 5, 2023 15:39
@ejohnson-96 ejohnson-96 requested review from namurphy and removed request for a team June 5, 2023 15:39
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs PlasmaPy Docs at http:https://docs.plasmapy.org notebooks Related to example Jupyter notebooks in docs/examples/ labels Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱

Our contributor guide has information on:

The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:

  • Try fixing CI / Python 3.11 test failures first.
  • Most pre-commit.ci - pr failures can be automagically fixed by commenting pre-commit.ci autofix below, followed by a git pull to bring the changes back to your computer.
  • If pre-commit.ci - pr says that a function is too long or complex, try breaking up that function into multiple short functions that each do one thing. See also these tips on writing clean scientific software.
  • If the CI / Documentation check ends with a cryptic error message, check out our documentation troubleshooting guide.
  • For a documentation preview, click on Details next to docs/readthedocs.org:plasmapy.

If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder.

Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples.

We thank you once again!

@ejohnson-96 ejohnson-96 marked this pull request as draft June 5, 2023 15:39
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c5bafff) 98.21% compared to head (1854d13) 98.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2196   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          98       98           
  Lines        8568     8568           
=======================================
  Hits         8415     8415           
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@namurphy namurphy added this to the Future milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http:https://docs.plasmapy.org notebooks Related to example Jupyter notebooks in docs/examples/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants