-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a separate factor for NFP to calculate umbilic configurations #819
base: master
Are you sure you want to change the base?
Conversation
…the form 1/NFP_umbilic_fac
… for a simple case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
flake8
desc/geometry/core.py|120 col 89| line too long (107 > 88 characters)
desc/geometry/core.py|367 col 89| line too long (107 > 88 characters)
desc/geometry/core.py|416 col 89| line too long (109 > 88 characters)
…ourier function, correct bug in Equilibrium NFP_umbilic_factor property def
…rs resolved but continuation method doesn't work for umbilic probably due to the way it's designed
nodes, | ||
Index[:, 2], | ||
nodes[:, 2] % (2 * np.pi / (self.NFP / self.NFP_umbilic_factor)), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you construct the grid, it's fine to give nodes
@@ -958,6 +985,9 @@ def _create_nodes( # noqa: C901 | |||
Toroidal grid resolution. | |||
NFP : int | |||
Number of field periods (Default = 1). | |||
NFP_umbilic_factor : float | |||
Rational number of the form 1/integer with integer>=1. | |||
This is needed for the umbilic torus design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the earlier description more
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
==========================================
- Coverage 95.42% 95.01% -0.41%
==========================================
Files 89 89
Lines 22434 22578 +144
==========================================
+ Hits 21407 21453 +46
- Misses 1027 1125 +98
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
An umbilic torus is a 3D shape with a continuous sharp edge that goes around three times toroidally before meeting itself. This shape can be thought of as a stellarator with a rational field period because the cross-section is only exactly identical (each sharp point completes a full poloidal rotation) after three toroidal turns.
Practically, these configurations are useful for resonant divertor design and simplifies divertor placement.
The objective of this PR is to add an additional factor that adds an integer NFP_umbilic_factor so that NFP -> NFP/NFP_umbilic_factor and make sure that the code runs without any issues.
To create an umbilic edge, we take the boundary of the stellarator and a 3D umbilic curve on the boundary and vary both the curve and the surface to obtain a stellarator that resembles an umbilic-torus-like shape.