Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change date in docs to be clearer #1209

Merged
merged 6 commits into from
Aug 23, 2024
Merged

change date in docs to be clearer #1209

merged 6 commits into from
Aug 23, 2024

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Aug 20, 2024

No description provided.

@dpanici dpanici added documentation Add documentation or better warnings etc. easy Short and simple to code or review labels Aug 20, 2024
@f0uriest
Copy link
Member

If we want to avoid ambiguity with our more worldly colleagues I'd vote for Jan 01 2024 type dates

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.41%. Comparing base (b1900b3) to head (ab446e1).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1209      +/-   ##
==========================================
- Coverage   95.42%   95.41%   -0.01%     
==========================================
  Files          89       89              
  Lines       22434    22434              
==========================================
- Hits        21407    21406       -1     
- Misses       1027     1028       +1     

see 1 file with indirect coverage changes

@YigitElma
Copy link
Collaborator

YigitElma commented Aug 21, 2024

Best git commit message ever lol

@YigitElma
Copy link
Collaborator

@dpanici how dare you reduce the code coverage🤣🤣🤣

@dpanici dpanici merged commit 69ef318 into master Aug 23, 2024
17 checks passed
@dpanici dpanici changed the title change date in docs to be consistent with MM-DD-YYYY format change date in docs to be clearer Aug 23, 2024
@dpanici dpanici deleted the dp/consistent-date branch August 23, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Add documentation or better warnings etc. easy Short and simple to code or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants