fourier bounce #1119
Draft
fourier bounce #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bounce integral for reasons scified in #968 (comment)
Needed for desc_grid_from_field_line_coords function to work correctly
The polynomial coefficients being for the local power basis expansion. Numerical errors with roots with small imagninary components not being found. Generalize and simplify logic to correct inversion of bounce points to all edge cases. Add unit tests for computing the bounce points.
to compute pitch at fatter banana orbits. Continue adding tests
Add checks. Do all preparation to allow for custom grid.
as required by test_bounce_averaged_drifts. Add tests for pitch_of_extrema.
0a5216c
to
8197f71
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
seem to working fine but the quadrature seems innaccurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1045. Improves bounce integration stuff for neoclassical compute funs with pseudospectral techniques.