Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd Order NAE Constraints #1036

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

2nd Order NAE Constraints #1036

wants to merge 38 commits into from

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented May 24, 2024

  • make tests for this

Copy link
Contributor

github-actions bot commented May 24, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     -5.04 +/- 10.11    | -2.74e-02 +/- 5.51e-02 |  5.17e-01 +/- 2.3e-02  |  5.45e-01 +/- 5.0e-02  |
 test_build_transform_fft_midres         |     -3.40 +/- 6.78     | -2.09e-02 +/- 4.17e-02 |  5.94e-01 +/- 8.3e-03  |  6.15e-01 +/- 4.1e-02  |
 test_build_transform_fft_highres        |     -3.38 +/- 5.05     | -3.39e-02 +/- 5.07e-02 |  9.70e-01 +/- 9.2e-03  |  1.00e+00 +/- 5.0e-02  |
 test_equilibrium_init_lowres            |     -2.28 +/- 10.20    | -8.82e-02 +/- 3.95e-01 |  3.78e+00 +/- 2.2e-01  |  3.87e+00 +/- 3.3e-01  |
 test_equilibrium_init_medres            |     +0.02 +/- 9.41     | +8.85e-04 +/- 4.13e-01 |  4.38e+00 +/- 2.7e-01  |  4.38e+00 +/- 3.1e-01  |
 test_equilibrium_init_highres           |     +4.35 +/- 8.05     | +2.47e-01 +/- 4.57e-01 |  5.93e+00 +/- 1.3e-01  |  5.68e+00 +/- 4.4e-01  |
 test_objective_compile_dshape_current   |     +4.15 +/- 2.29     | +1.58e-01 +/- 8.70e-02 |  3.96e+00 +/- 4.0e-02  |  3.80e+00 +/- 7.7e-02  |
 test_objective_compile_atf              |     +4.89 +/- 3.71     | +4.00e-01 +/- 3.03e-01 |  8.58e+00 +/- 2.9e-01  |  8.18e+00 +/- 8.8e-02  |
 test_objective_compute_dshape_current   |     +4.08 +/- 5.00     | +5.10e-05 +/- 6.24e-05 |  1.30e-03 +/- 5.8e-05  |  1.25e-03 +/- 2.4e-05  |
 test_objective_compute_atf              |     +9.47 +/- 4.51     | +3.99e-04 +/- 1.90e-04 |  4.61e-03 +/- 1.2e-04  |  4.21e-03 +/- 1.5e-04  |
 test_objective_jac_dshape_current       |     +1.53 +/- 9.87     | +5.75e-04 +/- 3.70e-03 |  3.80e-02 +/- 3.0e-03  |  3.75e-02 +/- 2.2e-03  |
 test_objective_jac_atf                  |     +2.00 +/- 3.90     | +3.71e-02 +/- 7.22e-02 |  1.89e+00 +/- 5.3e-02  |  1.85e+00 +/- 4.9e-02  |
 test_perturb_1                          |     +9.70 +/- 3.42     | +1.28e+00 +/- 4.51e-01 |  1.45e+01 +/- 4.1e-01  |  1.32e+01 +/- 1.8e-01  |
 test_perturb_2                          |     +1.67 +/- 4.43     | +3.10e-01 +/- 8.21e-01 |  1.88e+01 +/- 4.5e-01  |  1.85e+01 +/- 6.8e-01  |
 test_proximal_jac_atf                   |     +0.83 +/- 1.31     | +6.64e-02 +/- 1.05e-01 |  8.09e+00 +/- 9.2e-02  |  8.03e+00 +/- 5.1e-02  |
 test_proximal_freeb_compute             |     -0.81 +/- 1.21     | -1.47e-03 +/- 2.19e-03 |  1.79e-01 +/- 2.0e-03  |  1.80e-01 +/- 9.4e-04  |
 test_proximal_freeb_jac                 |     -1.51 +/- 3.65     | -1.13e-01 +/- 2.72e-01 |  7.34e+00 +/- 2.6e-01  |  7.45e+00 +/- 8.7e-02  |
 test_solve_fixed_iter                   |     -1.90 +/- 14.99    | -3.46e-01 +/- 2.73e+00 |  1.78e+01 +/- 2.0e+00  |  1.82e+01 +/- 1.9e+00  |

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 5.01044% with 455 lines in your changes missing coverage. Please review.

Project coverage is 93.55%. Comparing base (dd3f472) to head (5bcd15a).
Report is 13 commits behind head on master.

Files Patch % Lines
desc/objectives/nae_utils.py 1.36% 434 Missing ⚠️
desc/equilibrium/equilibrium.py 44.11% 19 Missing ⚠️
desc/objectives/getters.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
- Coverage   95.47%   93.55%   -1.92%     
==========================================
  Files          87       87              
  Lines       22277    22739     +462     
==========================================
+ Hits        21268    21274       +6     
- Misses       1009     1465     +456     
Files Coverage Δ
desc/objectives/utils.py 100.00% <ø> (ø)
desc/objectives/getters.py 93.97% <60.00%> (-1.09%) ⬇️
desc/equilibrium/equilibrium.py 93.27% <44.11%> (-2.43%) ⬇️
desc/objectives/nae_utils.py 32.72% <1.36%> (-64.51%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants