Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add android:minSdkVersion information #15

Closed
trungnn307 opened this issue Oct 2, 2014 · 1 comment
Closed

add android:minSdkVersion information #15

trungnn307 opened this issue Oct 2, 2014 · 1 comment
Assignees
@Pkmmte
Labels
enhancement

Comments

@trungnn307
Copy link

You should add android:minSdkVersion information in project usage. If i use app:shadow="true" attribute , project must be API 11 and above. Because function setLayerType in addShadow function is only available on API 11
@Pkmmte
Copy link
Owner

Pkmmte commented Oct 2, 2014

This shouldn't be an issue as it already checks for API compatibility before applying the shadow.
https://github.com/Pkmmte/CircularImageView/blob/master/circularimageview/src/main/java/com/pkmmte/view/CircularImageView.java#L358-L365

But you're right, I should document this more thoroughly. Feel free to re-open this issue if the problem persists.

Pkmmte added a commit that referenced this issue Oct 2, 2014
@Pkmmte
Fixed Layout Rendering Errors (#12 #15)
25fd1dd 
References proper default style in constructor. (Also renamed it now
that I know what it does)

Also, setLayerType() calls are now in a separate method with a TargetApi
annotation to fix minSdkVersion errors on some compilers.
@Pkmmte Pkmmte closed this as completed Oct 2, 2014
@Pkmmte Pkmmte self-assigned this Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pkmmte Pkmmte

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trungnn307 @Pkmmte