Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coverity #99

Merged
merged 3 commits into from
Jan 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Pkcs11Interop
[![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/Pkcs11Interop/Pkcs11Interop/blob/master/LICENSE.md)
[![AppVeyor](https://ci.appveyor.com/api/projects/status/lb1jxb4t4203g3t9?svg=true)](https://ci.appveyor.com/project/pkcs11interop/pkcs11interop)
[![Travis](https://travis-ci.org/Pkcs11Interop/Pkcs11Interop.svg?branch=master)](https://travis-ci.org/Pkcs11Interop/Pkcs11Interop)
[![Coverity](https://img.shields.io/coverity/scan/2961.svg)](https://scan.coverity.com/projects/pkcs11interop-pkcs11interop)
[![NuGet](https://img.shields.io/badge/nuget-pkcs11interop-blue.svg)](https://www.nuget.org/packages/Pkcs11Interop/)
[![Stack Overflow](https://img.shields.io/badge/so-pkcs11interop-blue.svg)](https://stackoverflow.com/questions/tagged/pkcs11interop)
[![Twitter](https://img.shields.io/badge/twitter-p11interop-blue.svg)](https://twitter.com/p11interop)
Expand Down
39 changes: 0 additions & 39 deletions build/build-for-coverity-scan.bat

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,8 @@ public AttributeValueException(ulong attribute, Exception innerException)
protected AttributeValueException(SerializationInfo info, StreamingContext context)
: base(info, context)
{
#if !COVERITY // To avoid false positive - CID 181201: Null pointer dereferences (REVERSE_INULL) >>> Null - checking "info" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
if (info == null)
throw new ArgumentNullException("info");
#endif

_attribute = (CKA)info.GetUInt32("Attribute");
}
Expand Down
2 changes: 0 additions & 2 deletions src/Pkcs11Interop/Pkcs11Interop/Common/Pkcs11Exception.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,8 @@ public Pkcs11Exception(string method, CKR rv)
protected Pkcs11Exception(SerializationInfo info, StreamingContext context)
: base(info, context)
{
#if !COVERITY // To avoid false positive - CID 181201: Null pointer dereferences (REVERSE_INULL) >>> Null - checking "info" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
if (info == null)
throw new ArgumentNullException("info");
#endif

_method = info.GetString("Method");
_rv = (CKR)info.GetUInt32("RV");
Expand Down
2 changes: 0 additions & 2 deletions src/Pkcs11Interop/Pkcs11Interop/Common/UnmanagedException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,8 @@ public UnmanagedException(string message, int errorCode)
protected UnmanagedException(SerializationInfo info, StreamingContext context)
: base(info, context)
{
#if !COVERITY // To avoid false positive - CID 181201: Null pointer dereferences (REVERSE_INULL) >>> Null - checking "info" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
if (info == null)
throw new ArgumentNullException("info");
#endif

bool errorCodeSet = info.GetBoolean("ErrorCodeSet");

Expand Down