Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elmah.io source #3956

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Fix elmah.io source #3956

merged 3 commits into from
Aug 8, 2022

Conversation

ThomasArdal
Copy link
Contributor

@ThomasArdal ThomasArdal commented Aug 8, 2022

When looking for 'New Error' it only makes sense to look for messages where isNew is true and the severity is either Error or Fatal.

@vercel
Copy link

vercel bot commented Aug 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview Aug 8, 2022 at 3:53PM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview Aug 8, 2022 at 3:53PM (UTC)

@dylburger dylburger added the User submitted Submitted by a user label Aug 8, 2022
@dylburger
Copy link
Contributor

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Aug 8, 2022
@dylburger
Copy link
Contributor

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@andrewjschuang
Copy link
Collaborator

@ThomasArdal thanks for the contribution! I've pushed a commit that adds the query to async run() and bumps the patch version of the source just to speed up the process.

@ThomasArdal
Copy link
Contributor Author

@andrewjschuang Good catch 🙌

@vunguyenhung vunguyenhung self-assigned this Aug 8, 2022
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
elmah.io_3956_2337.pdf

@vunguyenhung
Copy link
Collaborator

I will merge this PR for @ThomasArdal as he doesn't have merge permission for this repo 🙏

@vunguyenhung vunguyenhung merged commit 8a66904 into PipedreamHQ:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee User submitted Submitted by a user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants