Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eSignatures.io #3857 #3918

Merged
merged 8 commits into from
Aug 4, 2022
Merged

eSignatures.io #3857 #3918

merged 8 commits into from
Aug 4, 2022

Conversation

lcaresia
Copy link
Collaborator

@lcaresia lcaresia commented Aug 1, 2022

Oficial API don't have a way to register a webhook, so this PR only have the action.

Actions

  • Create Contract

@lcaresia lcaresia added the action New Action Request label Aug 1, 2022
@lcaresia lcaresia self-assigned this Aug 1, 2022
@vercel
Copy link

vercel bot commented Aug 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 9:06PM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 9:06PM (UTC)

@dylburger
Copy link
Contributor

dylburger commented Aug 1, 2022

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

michelle0927
michelle0927 previously approved these changes Aug 1, 2022
Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
eSignatures.pdf


@lcaresia on another note, I think we might need to contact with eSignatures team to get their help on the triggers right?

@lcaresia
Copy link
Collaborator Author

lcaresia commented Aug 2, 2022

@lcaresia on another note, I think we might need to contact with eSignatures team to get their help on the triggers right?

@vunguyenhung It's possible, you can use the custom webhook field when is creating the contract, but you can't create a external webhook using the oficial API.

@lcaresia
Copy link
Collaborator Author

lcaresia commented Aug 2, 2022

/approve

@vunguyenhung
Copy link
Collaborator

Hello @lcaresia, thanks for your information! I think we can merge this. I've created another Github issue here to track the remaining triggers #3928.

@lcaresia lcaresia merged commit 096f627 into master Aug 4, 2022
@lcaresia lcaresia deleted the esignatures branch August 4, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action New Action Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eSignatures.io
4 participants