Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unpublished Linkedin and Shopify components #10638

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

js07
Copy link
Contributor

@js07 js07 commented Feb 28, 2024

WHAT

Remove the following components:

  • Linkedin Query Analytics Finder Account Sample
  • Linkedin Query Analytics Finder Campaign Sample
  • Linkedin Query Analytics Finder
  • Shopify Create Customer
  • Shopify Create Order
  • Shopify Search Customers
  • Shopify Update Customer

WHY

These components have been unpublished from the Pipedream registry and should be removed from the repo so they are not re-published if updated.

The following components have been unpublished from the Pipedream
registry:

- Linkedin Query Analytics Finder Account Sample
- Linkedin Query Analytics Finder Campaign Sample
- Linkedin Query Analytics Finder
- Shopify Create Customer
- Shopify Create Order
- Shopify Search Customers
- Shopify Update Customer
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 4:59pm
pipedream-docs ⬜️ Ignored (Inspect) Mar 4, 2024 4:59pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Mar 4, 2024 4:59pm

@js07 js07 marked this pull request as ready for review February 29, 2024 00:27
@js07 js07 added this to Ready for PR review in Component (Source and Action) Backlog Feb 29, 2024
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Feb 29, 2024
lcaresia
lcaresia previously approved these changes Mar 1, 2024
@lcaresia lcaresia moved this from Ready for PR review to Ready for QA in Component (Source and Action) Backlog Mar 1, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to Ready for PR review in Component (Source and Action) Backlog Mar 4, 2024
@vunguyenhung vunguyenhung moved this from Ready for PR review to In QA in Component (Source and Action) Backlog Mar 4, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for release in Component (Source and Action) Backlog Mar 4, 2024
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Remove-unpublished-Linkedin-and-Shopify-components-10638-c10c0fa4c8c5450f92480313e4384f37

Fix merge conflict in pnpm-lock.yaml
@js07
Copy link
Contributor Author

js07 commented Mar 4, 2024

/approve

@js07 js07 merged commit a49b7cf into master Mar 4, 2024
10 checks passed
@js07 js07 deleted the remove-unpublished-components branch March 4, 2024 17:09
@michelle0927 michelle0927 moved this from Ready for release to Done in Component (Source and Action) Backlog Mar 4, 2024
luiidd pushed a commit to luiidd/pipedream that referenced this pull request Mar 7, 2024
The following components have been unpublished from the Pipedream
registry:

- Linkedin Query Analytics Finder Account Sample
- Linkedin Query Analytics Finder Campaign Sample
- Linkedin Query Analytics Finder
- Shopify Create Customer
- Shopify Create Order
- Shopify Search Customers
- Shopify Update Customer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee
Development

Successfully merging this pull request may close these issues.

None yet

4 participants