-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is signaly of the calibration marker used as scale value? #4
Comments
Hi Julian,
To be honest I’m not certain if this is an error or not. We almost never use this pdf conversion script as all our work is based on extracting raw waveform. If you are able to explore I welcome your clarification if this is indeed causing incorrect scaling and a pull request submission to fix it.
Best,
Pierre
From: Julian Klug ***@***.***>
Date: Tuesday, September 13, 2022 at 1:41 AM
To: PierreElias/IntroECG ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [PierreElias/IntroECG] Why is signaly of the calibration marker used as scale value? (Issue #4)
Thank you for this great work!
I was wondering why the y component of the signal from the calibration marker is used to scale both X and Y component of the leads. If I read your code correctly, np.min(signaly) of the marker will be used to scale X and np.max(signaly) will be used to scale Y. Although I see the point in scaling the y component Y of the leads by Y dimension of the marker, I don't understand why the X component of the leads should be scaled by the Y component of the marker.
Would you mind detailing your reasoning for this?
https://github.com/PierreElias/IntroECG/blob/b728633c49ef0ec3745c1ed4ffbb3e5ccec0719f/1-Waveform%20Extraction/ecg_pdf_to_dataframe.py#L150
—
Reply to this email directly, view it on GitHub<#4>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACTCEYV24CJVVIDIKP3M543V6AHZJANCNFSM6AAAAAAQLCTQDY>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Thank you for the input. I will try to look into this when I have a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you for this great work!
I was wondering why the y component of the signal from the calibration marker is used to scale both X and Y component of the leads. If I read your code correctly, np.min(signaly) of the marker will be used to scale X and np.max(signaly) will be used to scale Y. Although I see the point in scaling the y component Y of the leads by Y dimension of the marker, I don't understand why the X component of the leads should be scaled by the Y component of the marker.
Would you mind detailing your reasoning for this?
IntroECG/1-Waveform Extraction/ecg_pdf_to_dataframe.py
Line 150 in b728633
The text was updated successfully, but these errors were encountered: