Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/simplify description in APatch and KSU backed systems #30

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ThePedroo
Copy link
Member

Changes

This PR both improves the indentation of Rust code and also simplifies the module description when using a root impl that support the future web ui.

Why

This allows it to look nicer on module list, keeping it minimum, and only showing more info in the web UI.

Checkmarks

  • The modified functions have been tested.
  • Used the same indentation as the rest of the project.
  • Updated documentation (changelog).

This commit improves the indentation of zygiskd.
This commit improves the code that updates the module description, to be brief in root implementations that support web UI.
@CaptainThrowback
Copy link

In the current state, the description field on the module page is still a bit busy, with the monitor and daemon32/64 statuses all still there. If the idea is for the user to be able to get a quick view of whether ReZygisk is working, then my suggestion would be to instead use the status that the WebUI uses, where it says "Working", "Partially Working", or "Unknown". The monitor and daemon details should be accessible through the WebUI, so including them in the description would be unnecessary and redundant.

So the status would look like this in the case where everything is working as expected:
Screenshot_20240714-120949
Screenshot_20240714-120955

(Obviously you can use whatever emoji you want for the status, I just chose the green check mark because I had it handy. You could also use no emoji as well)

I hope that clarifies my suggestion.

@ThePedroo
Copy link
Member Author

I understand your point and I agree with it, I'll be working on it

@ThePedroo ThePedroo linked an issue Jul 15, 2024 that may be closed by this pull request
3 tasks
@ThePedroo
Copy link
Member Author

This WILL be delayed in favor of #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Only update module status in Root Manager if app doesn't support WebUI
2 participants