Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding parentIds for motion scan effect #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding parentIds for motion scan effect #46

wants to merge 2 commits into from

Conversation

PhRosenberger
Copy link
Member

As written in #45, the motion scan effect node is currently flying around besides the tree.
This PR should solve it.

@PhRosenberger PhRosenberger added the bug Something isn't working label Jun 18, 2024
@PhRosenberger PhRosenberger self-assigned this Jun 18, 2024
@PhRosenberger PhRosenberger linked an issue Jun 18, 2024 that may be closed by this pull request
Motion scan effect has no parents #45
Open
ClemensLinnhoff
ClemensLinnhoff requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@ClemensLinnhoff ClemensLinnhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in the corresponding issue. I do not see the motion scan effect producing false positives or false negatives. The detections are all valid, just at a different position than expected.

@PhRosenberger
Copy link
Member Author

See my comment in the corresponding issue. I do not see the motion scan effect producing false positives or false negatives. The detections are all valid, just at a different position than expected.

I just inserted the detection state error node for this.

@PhRosenberger
Copy link
Member Author

@TimoHinsemann as this PR inserts several parentIDs, I guess I also need to provide references for each of these new connections, right?

@PhRosenberger
Copy link
Member Author

This PR relates to #37 based on #36. We should somehow merge/discuss both concepts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoHinsemann TimoHinsemann Awaiting requested review from TimoHinsemann

@ChristophPopp ChristophPopp Awaiting requested review from ChristophPopp

@ClemensLinnhoff ClemensLinnhoff Awaiting requested review from ClemensLinnhoff

Requested changes must be addressed to merge this pull request.

Assignees

@PhRosenberger PhRosenberger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Motion scan effect has no parents
2 participants
@PhRosenberger @ClemensLinnhoff