Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font issues #6

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Fix font issues #6

merged 1 commit into from
Jan 25, 2022

Conversation

rgreinho
Copy link
Member

@rgreinho rgreinho commented Jan 22, 2022

Fixes issues related to the import and the usages of the fonts.

  • Adds font assets for the Dharma Gothic font.
  • Adds font-face rules for the Dharma Gothic font.
  • Uses css variables to define fonts:
    • --fonts-body
    • --font-headlines
  • Fixes Google font link
  • Removes the /sass folder since it is not being used. As per this
    issue, Override a theme's sass getzola/zola#837, only the static
    and templates folder can be used to override themes elements.
  • Add a new scss file for storing custom fonts if any.
  • Use the head block to load custom fonts.

Drive-by:

  • Adds CI task to run all the CI tasks at once.
  • Fixes SASS linter/formatter tasks.

@rgreinho rgreinho self-assigned this Jan 22, 2022
@rgreinho rgreinho marked this pull request as draft January 22, 2022 17:46
Fixes issues related to the import and the usages of the fonts.

- Adds font assets for the Dharma Gothic font.
- Adds `font-face` rules for the Dharma Gothic font.
- Uses css variables to define fonts:
    - --fonts-body
    - --font-headlines
- Fixes Google font `link`
- Removes the `/sass` folder since it is not being used. As per this
  issue, getzola/zola#837, only the `static`
  and `templates` folder can be used to override themes elements.
- Add a new scss file for storing custom fonts if any.
- Use the `head` block to load custom fonts.

Drive-by:
- Adds CI task to run all the CI tasks at once.
- Fixes SASS linter/formatter tasks.
@rgreinho rgreinho marked this pull request as ready for review January 22, 2022 20:58
Copy link
Contributor

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rendered the development site locally using the fonts branch and everything looks good and ran without errors. I wasn't able to check the drive-by items but I'll go ahead and approve this PR.

@rgreinho
Copy link
Member Author

Thanks @lalver1. I am going to merge it then. Once your account will be be created this will be done automatically by Kodiak :)

@rgreinho rgreinho merged commit 07c869e into main Jan 25, 2022
@rgreinho rgreinho deleted the fonts branch January 25, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants