Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add last login time for ldap.py #322

Closed
wants to merge 1 commit into from
Closed

Conversation

MUWASEC
Copy link

@MUWASEC MUWASEC commented May 22, 2024

get the information from ldap attribute lastLogon or lastLogonTimestamp based on https://serverfault.com/a/959783

get the information from ldap attribute lastLogon or lastLogonTimestamp based on https://serverfault.com/a/959783

Signed-off-by: muwa00 <[email protected]>
@Marshall-Hallenbeck
Copy link
Collaborator

@MUWASEC thanks for the PR! Are you able to mirror this in the SMB --users functionality so they are in parity?

@Marshall-Hallenbeck Marshall-Hallenbeck added the enhancement New feature or request label May 23, 2024
@MUWASEC
Copy link
Author

MUWASEC commented May 23, 2024

@MUWASEC thanks for the PR! Are you able to mirror this in the SMB --users functionality so they are in parity?

i already try this but it looks impossible to me, as far as i know the smb one using samr and i can't find any resource (skill issue) to get last login time from samr. i did try & error get the properties based on https://github.com/rrthomas/xpra/blob/6d0dc2b1207b6e1c27d2bc64af1d2de4d63ae98c/xpra/platform/win32/lsa_logon_lib.py#L379 like below but there's no output or perhaps "LogonTime" is not exist

image

at first i thought nxc use custom properties or module for the SMB, but after i set the properties to "FullName" it give me the value of user full name. so no, i can't mirror the functionality into the SMB one

@Marshall-Hallenbeck
Copy link
Collaborator

I'm wary of adding functionality to one when the other doesn't have it. Additionally, this is another column that sort of makes the output unreadable unless your screen is large... maybe we add this to some sort of extended output flag?

@MUWASEC MUWASEC closed this by deleting the head repository Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants