[WIP] Add QubitUnitaryFusion pass from development tutorial #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul0403
reviewed
Jun 27, 2024
| namespace catalyst { | ||
| namespace quantum { | ||
|
|
||
| #define GEN_PASS_DEF_QubitUnitaryFusionPASS |
There was a problem hiding this comment.
#define GEN_PASS_DEF_QUBITUNITARYFUSIONPASS
|
Paul: No need for changelog since this is do-not-merge |
paul0403
reviewed
Jun 27, 2024
|
|
||
| #define DEBUG_TYPE "qubit-unitary-fusion" | ||
|
|
||
| #include "mlir/Dialect/Linalg/Ops.h" |
There was a problem hiding this comment.
I think this file does not exist. The closest I can find is #include "mlir/Dialect/Linalg/IR/Linalg.h", so I would go find in the mlir repo where the operations you want are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add the
QubitUnitaryFusionpass from the compiler passes development site. Struggling with the very basics and boilerplate 馃珷My approach: mimick behavior from
ChainedHadamard.cppandremove_chained_self_inverse.cpp, take on advice added in #872 and use code snippets from compiler passes. The error messages are rather cryptic at this point so not sure how to continue.