Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the clang-format config file to ensure consistency with PL code style #295

Closed
wants to merge 5 commits into from

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Oct 2, 2023

This PR includes following updates in the code-base,

  • Update the C++ clang-format config file to ensure consistency with PL code style introduced here.
  • Add a missing std library to the DataView class.
  • Add missing headers to a few dialects files.
  • Fix pylint warnings and useless-suppression

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a0f7b93) 99.51% compared to head (323f83e) 99.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   99.51%   99.51%   -0.01%     
==========================================
  Files          40       40              
  Lines        7266     7248      -18     
  Branches      423      423              
==========================================
- Hits         7231     7213      -18     
  Misses         17       17              
  Partials       18       18              
Files Coverage Δ
frontend/catalyst/compilation_pipelines.py 100.00% <ø> (ø)
frontend/catalyst/jax_primitives.py 97.08% <100.00%> (ø)
frontend/catalyst/pennylane_extensions.py 99.63% <ø> (ø)
frontend/catalyst/utils/extra_bindings.py 100.00% <ø> (ø)
runtime/extensions/StateVectorLQubitDynamic.hpp 100.00% <100.00%> (ø)
runtime/include/DataView.hpp 100.00% <100.00%> (ø)
runtime/include/Exception.hpp 100.00% <100.00%> (ø)
runtime/lib/backend/common/CacheManager.hpp 100.00% <100.00%> (ø)
runtime/lib/backend/common/QubitManager.hpp 97.50% <100.00%> (ø)
runtime/lib/backend/common/Utils.hpp 100.00% <100.00%> (ø)
... and 15 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@maliasadi maliasadi added runtime Pull requests that update the runtime compiler Pull requests that update the compiler labels Dec 6, 2023
@dime10
Copy link
Collaborator

dime10 commented Jul 12, 2024

I'll close this as stale, but we can reopen after a discussion about how we want to move forward with this.

@dime10 dime10 closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Pull requests that update the compiler runtime Pull requests that update the runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants