Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add third config to BIDSLayout that defines cohort entity #1143

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 15, 2024

Closes none. The BIDSLayout with bids and derivatives configs was not identifying cohort, even though I had invalid_filters="allow". I thought that invalid_filters="allow" would let BIDSLayout find any entity-formatted strings in filenames, but apparently that's not true.

Changes proposed in this pull request

  • Add a new pybids config file that include cohort, but not datatype (which conflicts with the existing datatype definition).

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (13eff94) to head (7a74864).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1143   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files          53       53           
  Lines        6667     6669    +2     
  Branches      924      924           
=======================================
+ Hits         5551     5553    +2     
  Misses        907      907           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Apr 16, 2024
@tsalo tsalo changed the title Fix cohort grabbing Add third config to BIDSLayout that defines cohort entity Apr 16, 2024
@tsalo tsalo merged commit fe0d569 into PennLINC:main Apr 16, 2024
20 checks passed
@tsalo tsalo deleted the fix-cohort branch April 16, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant