Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #290

Merged
merged 21 commits into from
Feb 1, 2024
Merged

Improve documentation #290

merged 21 commits into from
Feb 1, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 31, 2024

Closes none. One slightly, but not meaningfully, breaking change is that the CuBIDS class is no longer accessible through cubids (i.e., you can't do from cubids import CuBIDS). Instead, you need the submodule now (from cubids.cubids import CuBIDS).

Changes proposed:

  • Add a glossary that defines some of the core terms.
  • Add API page.
  • Split out CLI documentation from general usage walkthrough page.
  • Remove duplicate README.rst in docs folder.
  • Go through documentation and try to split sentences across lines on punctuation.
  • Add a section to README on what CuBIDS is not meant to do.
  • Add links from API documentation to GitHub code.

@tsalo tsalo added the documentation Improvements or additions to documentation label Jan 31, 2024
@tsalo tsalo marked this pull request as ready for review January 31, 2024 16:35
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

docs/about.rst Show resolved Hide resolved
docs/about.rst Show resolved Hide resolved
docs/about.rst Outdated Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
docs/links.rst Outdated Show resolved Hide resolved
docs/usage.rst Show resolved Hide resolved
is an optional dependency of ``CuBIDS``, we use it here to demonstrate its
powerful integration with ``CuBIDS`` and the benefits it can provide its users.
conda environment titled "cubids".
In this example, we use validator version ``1.7.2``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how behind is this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roughly 3 years old. Probably a good idea to update the example and notebooks at some point.

docs/example.rst Outdated Show resolved Hide resolved
docs/example.rst Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0988440) 62.02% compared to head (597b5e0) 62.13%.

Files Patch % Lines
cubids/__about__.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   62.02%   62.13%   +0.11%     
==========================================
  Files           8        9       +1     
  Lines        1572     1582      +10     
==========================================
+ Hits          975      983       +8     
- Misses        597      599       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 4d9704d into PennLINC:main Feb 1, 2024
8 checks passed
@tsalo tsalo deleted the improve-docs branch February 1, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants