This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Cleanup Ibft executors #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjHare
approved these changes
Feb 25, 2019
jframe
reviewed
Feb 25, 2019
| @@ -214,21 +215,20 @@ | |||
|
|
|||
| final IbftGossip gossiper = new IbftGossip(uniqueMessageMulticaster); | |||
|
|
|||
| final ScheduledExecutorService timerExecutor = Executors.newSingleThreadScheduledExecutor(); | |||
There was a problem hiding this comment.
Could be good idea to use the MonitoredExecutors.newFixedThreadPool so we can give our thread pool a name and get some free metrics as well.
| try { | ||
| timerExecutor.awaitTermination(5, TimeUnit.SECONDS); | ||
| } catch (final InterruptedException e) { | ||
| LOG.error("Failed to shutdown timerexecutor"); |
There was a problem hiding this comment.
nit: thinking this should be "Failed to shutdown timer executor"
jframe
approved these changes
Feb 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly clean up executors used for IBFT timers.