This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fixed Difficulty calculator #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
700edf4
to
497c6aa
Compare
rain-on
reviewed
Jan 28, 2019
pantheon/src/main/java/tech/pegasys/pantheon/controller/PantheonController.java
Outdated
Show resolved
Hide resolved
17a8293
to
35401ca
Compare
ajsutton
approved these changes
Jan 29, 2019
| import org.junit.Before; | ||
| import org.junit.Test; | ||
|
|
||
| public class FixedMiningDifficultyAcceptanceTest extends AcceptanceTestBase { |
There was a problem hiding this comment.
I think this can just be removed now that dev mode is using the fixed difficulty calculator - pretty much every AT is using it and mining transactions so if it ever breaks they'll all grind to a halt because of the increased difficulty.
| @@ -0,0 +1,40 @@ | |||
| { | |||
There was a problem hiding this comment.
Can just use dev.json now.
| @@ -120,6 +121,24 @@ public PantheonNode createArchiveNodeWithP2pDisabled(final String name) throws I | |||
| .build()); | |||
| } | |||
|
|
|||
| public Node createFixedDifficultyMinerNode(final String name) throws IOException { | |||
There was a problem hiding this comment.
--network DEV will be enough to get this now.
There was a problem hiding this comment.
or I could remove the method since fixed difficulty is being used in tests by default and the fixed difficulty AT has been deleted.
…Mainnet Protocol Schedule.
f671ab6
to
ccf20a0
Compare
vinistevam
pushed a commit
to vinistevam/pantheon
that referenced
this pull request
Jan 29, 2019
* created fixed difficulty calculator. * Use fixed calculator at the right spot. * Use fixeddifficulty in the main dev.json file. * Removed development difficulty calculators.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed difficulty calculator.
Goal is to have a simple replacement in genesis blocks for devmode options currently floating around.