Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

IBFT Integration Tests - Future Height #591

Merged
merged 6 commits into from
Jan 21, 2019

Conversation

rain-on
Copy link
Contributor

@rain-on rain-on commented Jan 17, 2019

This adds tests to ensure the IBFT capability handles the chain updating
"under" the state machine.

This adds tests to ensure the IBFT capability handles the chain updating
"under" the state machine.
@rain-on rain-on requested review from jframe and CjHare January 17, 2019 10:13

private final int NETWORK_SIZE = 5;

// Local node is not the first proposer for the current round.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this message correct? where or what is local node ...I don't see a field with that name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to handle this - but all integration tests are exercising the ibftController embedded in the TestContext - which I treat/consider the localNode.

Would love better nomenclature.

Copy link
Contributor

@CjHare CjHare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but I'll leave it open for @jframe take a look tomorrow

@@ -37,7 +37,7 @@
public class TestHelpers {

public static SignedData<CommitPayload> createSignedCommentPayload(
final Block block, final KeyPair signingKeyPair, final ConsensusRoundIdentifier roundId) {
final ConsensusRoundIdentifier roundId, final Block block, final KeyPair signingKeyPair) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the consistency with other methods 👍

@rain-on rain-on merged commit ab06f49 into PegaSysEng:master Jan 21, 2019
@rain-on rain-on deleted the int_test_futureHeight branch January 24, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants