This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fixing up acceptance test #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-acceptance-test
lucassaldanha
approved these changes
Nov 28, 2018
| @@ -47,6 +49,7 @@ protected AcceptanceTestBase() { | |||
| transactions = new Transactions(accounts); | |||
| web3 = new Web3(new Web3Transactions()); | |||
| pantheon = new PantheonNodeFactory(); | |||
| contract = new ContractVerifier(accounts.getPrimaryBenefactor()); | |||
There was a problem hiding this comment.
NIT: naming this variable as contract can be misleading. Shouldn't we name it contractVerifier?
There was a problem hiding this comment.
Haha, you know that was it's name originally, I'll change it back
| */ | ||
| package tech.pegasys.pantheon.tests.acceptance.dsl.condition.eth; | ||
|
|
||
| public class ExpectContractTransactionReciept {} |
There was a problem hiding this comment.
TYPO: ExpectContractTransactionRecIEpt -> ExpectContractTransactionRecEIpt
…p-acceptance-test
…p-acceptance-test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I discovered that Web3j is calling EthGetTransactionReceipt as part of it's contract deployment code.
Meaning the acceptance test that validates the correctness of the EthGetTransactionReceipt was not as good or 'correct' test as it should be.
The focus of this PR was to change the AT to centre on the state of the transaction receipt and remove the valueless duplicate call (by removing the one in the AT).