This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-1742] Added host whitelist for Json-RPC. #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0e1a6c
to
52ac6a9
Compare
CjHare
reviewed
Nov 22, 2018
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpService.java
Outdated
Show resolved
Hide resolved
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcConfiguration.java
Outdated
Show resolved
Hide resolved
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpService.java
Outdated
Show resolved
Hide resolved
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpService.java
Outdated
Show resolved
Hide resolved
...rc/test/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpServiceHostWhitelistTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpServiceHostWhitelistTest.java
Outdated
Show resolved
Hide resolved
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
CjHare
reviewed
Nov 23, 2018
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpService.java
Outdated
Show resolved
Hide resolved
...rc/test/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpServiceHostWhitelistTest.java
Outdated
Show resolved
Hide resolved
477089d
to
d9f9487
Compare
ajsutton
approved these changes
Dec 6, 2018
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcConfiguration.java
Outdated
Show resolved
Hide resolved
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcConfiguration.java
Outdated
Show resolved
Hide resolved
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpService.java
Outdated
Show resolved
Hide resolved
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpService.java
Outdated
Show resolved
Hide resolved
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpService.java
Outdated
Show resolved
Hide resolved
CjHare
reviewed
Dec 6, 2018
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcConfiguration.java
Outdated
Show resolved
Hide resolved
40a7ae7
to
58c680f
Compare
…stead of failing in the RPC logic.
f8faf38
to
2231735
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Implemented a hostname whitelist for the JSON RPC service, as suggested by trail-of-bits to avoid DNS rebind attacks.
New behaviour:
A new CLI option has been added -
--host-whitelist. This argument can take a few values:*enables connections from all hostsIf this argument is not specified, it will default to
localhostand only permit connections that containlocalhostin theHostheader of the request.Fixed Issue(s)
fixes #244