This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Reduce log level when invalid messages received from peers #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gException in DeFramer as a routine event representing a malformed message.
ajsutton
commented
Nov 18, 2018
| @@ -32,7 +32,7 @@ public static void main(final String... args) { | |||
| new BlockImporter(), | |||
| new RunnerBuilder(), | |||
| new PantheonControllerBuilder(), | |||
| new Builder()); | |||
| new SynchronizerConfiguration.Builder()); | |||
There was a problem hiding this comment.
I admit this change is completely unrelated to this PR but just changes which import we use to make things more readable.
rain-on
reviewed
Nov 18, 2018
ethereum/p2p/src/main/java/tech/pegasys/pantheon/ethereum/p2p/rlpx/framing/Framer.java
Show resolved
Hide resolved
rain-on
approved these changes
Nov 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update
DeFramerto treatFramingExceptionas an indication that an invalid message was received - log the error at debug level and disconnect withBREACH_OF_PROTOCOLrather than logging at error level.Update
Framerto ensure that it throwsFramingExceptionfor any invalid message situations, including being unable to decompress a message.Given that
SnappyCompressoris the only implementation ofCompressorremove the interface andCompressionException(whichSnappyCompressorwas failing to convert exceptions to anyway).Fixed Issue(s)
fixes #251