Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PRIV-65] eea_getTransactionCount fails if account has not interacted with private state #1367

Merged
merged 2 commits into from
Apr 29, 2019

Conversation

iikirilov
Copy link
Contributor

@iikirilov iikirilov commented Apr 29, 2019

PR description

Steps to reproduce:

  1. get nonce for account a for privacy group x
  2. make a transaction with account a
  3. get nonce for account b for privacy group x

Result

Panthoen throws NullPointerException when executing Quantity.create(maybePrivateSender.getNonce() becuase maybePrivateSender is null

Expected

The nonce should be 0

Fixed Issue(s)

PRIV-65

@iikirilov iikirilov changed the title [PRIV-65] Tests [PRIV-65] eea_getTransactionCount fails if account has not interacted with private state Apr 29, 2019
Copy link
Contributor

@ekellstrand ekellstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekellstrand ekellstrand merged commit eace785 into PegaSysEng:master Apr 29, 2019
MadelineMurray pushed a commit to MadelineMurray/pantheon that referenced this pull request Apr 29, 2019
… with private state (PegaSysEng#1367)

* Fix eea transaction count if account is null in privacy group state

* Fix failing acceptance test

- expected value was generated with the wrong privacy group
MadelineMurray added a commit that referenced this pull request Apr 29, 2019
notlesh pushed a commit to notlesh/pantheon that referenced this pull request May 4, 2019
… with private state (PegaSysEng#1367)

* Fix eea transaction count if account is null in privacy group state

* Fix failing acceptance test

- expected value was generated with the wrong privacy group
notlesh pushed a commit to notlesh/pantheon that referenced this pull request May 14, 2019
… with private state (PegaSysEng#1367)

* Fix eea transaction count if account is null in privacy group state

* Fix failing acceptance test

- expected value was generated with the wrong privacy group
@iikirilov iikirilov deleted the priv-65 branch August 16, 2019 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants