Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PAN-2362] permissioning cli smart contract #1116

Merged
merged 11 commits into from
Mar 18, 2019
Merged

[PAN-2362] permissioning cli smart contract #1116

merged 11 commits into from
Mar 18, 2019

Conversation

macfarla
Copy link
Contributor

PR description

added CLI options for smart contract node permissioning
--permissions-nodes-contract-address
--permissions-nodes-contract-enabled

Fixed Issue(s)

fixes #PAN-2362

Copy link
Contributor

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks ok. However, I don't think we should make the contract address optional when enabling smart contract based permissioning. I'd like us to get to an agreement before merging this PR.

Copy link
Contributor

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit f9c8352 into PegaSysEng:master Mar 18, 2019
@macfarla macfarla deleted the pan-2362-permissioning-cli-smart-contract branch March 18, 2019 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants