Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify application name with an env variable #9

Merged
merged 1 commit into from
Oct 13, 2019
Merged

Add ability to specify application name with an env variable #9

merged 1 commit into from
Oct 13, 2019

Conversation

nightah
Copy link
Contributor

@nightah nightah commented Oct 2, 2019

As per the title, I've also included updates to the README.md on how to utilise this.
Tested locally prior to PRing.

@nightah
Copy link
Contributor Author

nightah commented Oct 10, 2019

@Pe46dro any chance we can have this merged anytime soon?

@Pe46dro Pe46dro merged commit 81225cc into Pe46dro:master Oct 13, 2019
@nightah
Copy link
Contributor Author

nightah commented Nov 15, 2019

@Pe46dro: I've noticed that despite the merge the latest version doesn't appears to include these changes, do you need to create a new tag in your CI pipeline to ensure this is built into the docker image?

@nightah nightah deleted the feature-app-name branch December 3, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants