fix: maybe fixes cmd+click, remove all underlines (marimo-team#1463)

* remove all underlines

* add ctrl

frontend/src/core/codemirror/go-to-definition/underline.ts

@@ -15,7 +15,7 @@ const underlineDecoration = Decoration.mark({ class: "underline" });
 
 // State Effects
 const addUnderline = StateEffect.define<{ from: number; to: number }>();
-const removeUnderline = StateEffect.define<{ from: number; to: number }>();
+const removeUnderlines = StateEffect.define();
 
 // Underline Field
 export const underlineField = StateField.define<DecorationSet>({
@@ -29,11 +29,8 @@ export const underlineField = StateField.define<DecorationSet>({
         newUnderlines = underlines.update({
           add: [underlineDecoration.range(effect.value.from, effect.value.to)],
         });
-      } else if (effect.is(removeUnderline)) {
-        newUnderlines = underlines.update({
-          filter: (from, to) =>
-            from !== effect.value.from || to !== effect.value.to,
-        });
+      } else if (effect.is(removeUnderlines)) {
+        newUnderlines = Decoration.none;
       }
     }
     return newUnderlines;
@@ -111,7 +108,7 @@ class MetaUnderlineVariablePlugin {
   };
 
   private keydown = (event: KeyboardEvent) => {
-    if (event.key === "Meta") {
+    if (event.key === "Meta" || event.key === "Ctrl") {
       this.commandKey = true;
     }
   };
@@ -136,15 +133,15 @@ class MetaUnderlineVariablePlugin {
   };
 
   private keyup = (event: KeyboardEvent) => {
-    if (event.key === "Meta") {
+    if (event.key === "Meta" || event.key === "Ctrl") {
       this.commandKey = false;
       this.clearUnderline();
     }
   };
 
   private clearUnderline() {
     if (this.hoveredRange) {
-      this.view.dispatch({ effects: removeUnderline.of(this.hoveredRange) });
+      this.view.dispatch({ effects: removeUnderlines.of(null) });
       this.hoveredRange = null;
     }
   }