Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option for mixed precision dtype to enable running on cpus #31

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat: add option for mixed precision dtype to enable running on cpus #31

merged 1 commit into from
Apr 16, 2024

Conversation

dgcnz
Copy link
Contributor

@dgcnz dgcnz commented Apr 12, 2024

Solves #26

Changes:

  • Add optional parameter amp_dtype

One can now run RoMa on cpu by specifying amp_dtype=torch.float32 like so:

roma_model = roma_outdoor(device=device, amp_dtype=torch.float32)

@Parskatt
Copy link
Owner

Parskatt commented Apr 16, 2024 •
edited
Loading

Seems good, did you check that it works?
Relatedly I should probably add some tests haha.

@Parskatt
Copy link
Owner

I'll merge it anyway, shouldn't be any issues I think.

@Parskatt Parskatt merged commit f6d664b into Parskatt:main Apr 16, 2024
@dgcnz dgcnz mentioned this pull request Apr 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgcnz @Parskatt