fix: correct iconstate varedited disposals and forbid their use. #26536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burzah
approved these changes
Aug 18, 2024
DGamerL
approved these changes
Aug 19, 2024
Hearstrings
pushed a commit
to Hearstrings/Paradise-SS220
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR runs the pre-existing UpdatePaths from #24249 on all station maps, and adds a maplint preventing further varedits to disposals pipes icon states.
I have no idea why these weren't caught as part of #24249; maybe they were reverted accidentally, but the scripts itself seems exhaustive as maplint doesn't complain after running it again.
Why It's Good For The Game
These were meant to have been fixed in March.
Images
Big Station Images
Testing
Ran maplint, visual inspection, filtered views of SDMM to ensure that changes didn't cause any disconnected pipes or networks.
Declaration
Changelog
NPFC