Skip to content

Commit

Permalink
[FLINK-7111] [scala-shell] Disable external jar test
Browse files Browse the repository at this point in the history
This closes apache#4288.
  • Loading branch information
zentol committed Jul 11, 2017
1 parent 74adb84 commit d0e5295
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 58 deletions.
55 changes: 0 additions & 55 deletions flink-scala-shell/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -242,61 +242,6 @@ under the License.
</executions>
</plugin>

<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<version>2.4</version><!--$NO-MVN-MAN-VER$-->
<executions>
<execution>
<id>create-library-loading-jar</id>
<phase>process-test-classes</phase>
<goals>
<goal>single</goal>
</goals>
<configuration>
<!--<archive>-->
<!--<manifest>-->
<!--<mainClass>org.apache.flink.test.classloading.jar.KMeansForTest</mainClass>-->
<!--</manifest>-->
<!--</archive>-->
<finalName>customjar</finalName>
<attach>false</attach>
<descriptors>
<descriptor>src/test/assembly/test-scalashell-customjar-assembly.xml</descriptor>
</descriptors>
</configuration>
</execution>
</executions>
</plugin>


<!--Remove the the classes in the jar package from the test-classes directory since they
musn't be in the classpath when running ScalaShellITCase to actually test loading
of external jars.-->
<plugin>
<artifactId>maven-clean-plugin</artifactId>
<version>2.5</version><!--$NO-MVN-MAN-VER$-->
<executions>
<execution>
<id>remove-classloading-test-dependencies</id>
<phase>process-test-classes</phase>
<goals>
<goal>clean</goal>
</goals>
<configuration>
<excludeDefaultDirectories>true</excludeDefaultDirectories>
<filesets>
<fileset>
<directory>${project.build.testOutputDirectory}</directory>
<includes>
<include>**/jar/*.class</include>
</includes>
</fileset>
</filesets>
</configuration>
</execution>
</executions>
</plugin>

</plugins>
</build>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import org.apache.flink.runtime.minicluster.StandaloneMiniCluster
import org.apache.flink.configuration.{ConfigConstants, Configuration, GlobalConfiguration}
import org.apache.flink.test.util.TestBaseUtils
import org.apache.flink.util.TestLogger
import org.junit.{AfterClass, Assert, BeforeClass, Test}
import org.junit.{AfterClass, Assert, BeforeClass, Ignore, Test}

import scala.concurrent.{Await, Future}
import scala.concurrent.duration.FiniteDuration
Expand Down Expand Up @@ -164,7 +164,11 @@ class ScalaShellITCase extends TestLogger {
Assert.assertTrue(output.contains("WC(world,10)"))
}

/** Submit external library */
/**
* Submit external library.
* Disabled due to FLINK-7111.
*/
@Ignore
@Test
def testSubmissionOfExternalLibraryBatch: Unit = {
val input =
Expand All @@ -184,7 +188,11 @@ class ScalaShellITCase extends TestLogger {
Assert.assertTrue(output.contains("\nHELLO 42"))
}

/** Submit external library */
/**
* Submit external library.
* Disabled due to FLINK-7111.
*/
@Ignore
@Test
def testSubmissionOfExternalLibraryStream: Unit = {
val input =
Expand Down

0 comments on commit d0e5295

Please sign in to comment.