forked from apache/flink
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[hotfix][network,tests] Add new unit test for RemoteInputChannel#retr…
…iggerSubpartitionRequest It is necessary for flip1 to make sure the PartitionNotFoundException would be setted on the RemoteInputChannel while retriggering partition request, so a new unit test is added to cover this case.
- Loading branch information
1 parent
0189db4
commit 9f2338c
Showing
3 changed files
with
125 additions
and
0 deletions.
There are no files selected for viewing
50 changes: 50 additions & 0 deletions
50
...k-runtime/src/test/java/org/apache/flink/runtime/io/network/TestingConnectionManager.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.runtime.io.network; | ||
|
|
||
| /** | ||
| * A dummy implementation of the {@link ConnectionManager} which is mainly used for creating | ||
| * {@link PartitionRequestClient} instance in tests. | ||
| */ | ||
| public class TestingConnectionManager implements ConnectionManager { | ||
|
|
||
| @Override | ||
| public void start() {} | ||
|
|
||
| @Override | ||
| public PartitionRequestClient createPartitionRequestClient(ConnectionID connectionId) { | ||
| return new TestingPartitionRequestClient(); | ||
| } | ||
|
|
||
| @Override | ||
| public void closeOpenChannelConnections(ConnectionID connectionId) {} | ||
|
|
||
| @Override | ||
| public int getNumberOfActiveConnections() { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public int getDataPort() { | ||
| return -1; | ||
| } | ||
|
|
||
| @Override | ||
| public void shutdown() {} | ||
| } |
50 changes: 50 additions & 0 deletions
50
...time/src/test/java/org/apache/flink/runtime/io/network/TestingPartitionRequestClient.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.runtime.io.network; | ||
|
|
||
| import org.apache.flink.runtime.event.TaskEvent; | ||
| import org.apache.flink.runtime.io.network.partition.ResultPartitionID; | ||
| import org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel; | ||
|
|
||
| /** | ||
| * A dummy implementation of the {@link PartitionRequestClient} instance which is mainly used | ||
| * for tests to avoid mock. | ||
| */ | ||
| public class TestingPartitionRequestClient implements PartitionRequestClient { | ||
|
|
||
| @Override | ||
| public void requestSubpartition( | ||
| ResultPartitionID partitionId, | ||
| int subpartitionIndex, | ||
| RemoteInputChannel inputChannel, | ||
| int delayMs) { | ||
| } | ||
|
|
||
| @Override | ||
| public void notifyCreditAvailable(RemoteInputChannel inputChannel) { | ||
| } | ||
|
|
||
| @Override | ||
| public void sendTaskEvent(ResultPartitionID partitionId, TaskEvent event, RemoteInputChannel inputChannel) { | ||
| } | ||
|
|
||
| @Override | ||
| public void close(RemoteInputChannel inputChannel) { | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters