[hotfix] Remove redundant FutureUtils#getFailedFuture

FutureUtils#completedExceptionally does exactly the same.
Pance · Oct 30, 2017 · 747cf82 · 747cf82
1 parent 152f6c9
commit 747cf82
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/...src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java b/...src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java
@@ -169,7 +169,7 @@ private CompletableFuture<KvStateResponse> getState(
 
  final InetSocketAddress serverAddress = location.getKvStateServerAddress(keyGroupIndex);
  if (serverAddress == null) {
- return FutureUtils.getFailedFuture(new UnknownKvStateKeyGroupLocationException(getServerName()));
+ return FutureUtils.completedExceptionally(new UnknownKvStateKeyGroupLocationException(getServerName()));
  } else {
  // Query server
  final KvStateID kvStateId = location.getKvStateID(keyGroupIndex);

diff --git a/...me/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyImpl.java b/...me/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyImpl.java
@@ -43,7 +43,7 @@
 public class KvStateClientProxyImpl extends AbstractServerBase<KvStateRequest, KvStateResponse> implements KvStateClientProxy {
 
  private static final CompletableFuture<ActorGateway> UNKNOWN_JOB_MANAGER =
- FutureUtils.getFailedFuture(new UnknownJobManagerException());
+ FutureUtils.completedExceptionally(new UnknownJobManagerException());
 
  /** Number of threads used to process incoming requests. */
  private final int queryExecutorThreads;

diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java b/flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
@@ -445,20 +445,4 @@ public void onComplete(Throwable failure, T success) throws Throwable {
 
  return result;
  }
-
- // ------------------------------------------------------------------------
- // Future Completed with an exception.
- // ------------------------------------------------------------------------
-
- /**
- * Returns a {@link CompletableFuture} that has failed with the exception
- * provided as argument.
- * @param throwable the exception to fail the future with.
- * @return The failed future.
- */
- public static <T> CompletableFuture<T> getFailedFuture(Throwable throwable) {
- CompletableFuture<T> failedAttempt = new CompletableFuture<>();
- failedAttempt.completeExceptionally(throwable);
- return failedAttempt;
- }
 }