Skip to content

Commit

Permalink
[FLINK-11197][tests] Improve migration test comments about how to gen…
Browse files Browse the repository at this point in the history
…erate snapshots
  • Loading branch information
hequn8128 authored and zentol committed Jan 9, 2019
1 parent 3702029 commit 6650d74
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public class BucketingSinkMigrationTest {
/**
* TODO change this to the corresponding savepoint version to be written (e.g. {@link MigrationVersion#v1_3} for 1.3)
* TODO and remove all @Ignore annotations on write*Snapshot() methods to generate savepoints
* TODO Note: You should generate the savepoint based on the release branch instead of the master.
*/
private final MigrationVersion flinkGenerateSavepointVersion = null;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ public class FlinkKafkaConsumerBaseMigrationTest {
/**
* TODO change this to the corresponding savepoint version to be written (e.g. {@link MigrationVersion#v1_3} for 1.3)
* TODO and remove all @Ignore annotations on write*Snapshot() methods to generate savepoints
* TODO Note: You should generate the savepoint based on the release branch instead of the master.
*/
private final MigrationVersion flinkGenerateSavepointVersion = null;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public class FlinkKinesisConsumerMigrationTest {
/**
* TODO change this to the corresponding savepoint version to be written (e.g. {@link MigrationVersion#v1_3} for 1.3)
* TODO and remove all @Ignore annotations on the writeSnapshot() method to generate savepoints
* TODO Note: You should generate the savepoint based on the release branch instead of the master.
*/
private final MigrationVersion flinkGenerateSavepointVersion = null;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ public static Collection<Tuple2<MigrationVersion, Long>> parameters () {
/**
* TODO change this to the corresponding savepoint version to be written (e.g. {@link MigrationVersion#v1_3} for 1.3)
* TODO and remove all @Ignore annotations on write*Snapshot() methods to generate savepoints
* TODO Note: You should generate the savepoint based on the release branch instead of the master.
*/
private final MigrationVersion flinkGenerateSavepointVersion = null;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public class CEPMigrationTest {
/**
* TODO change this to the corresponding savepoint version to be written (e.g. {@link MigrationVersion#v1_3} for 1.3)
* TODO and remove all @Ignore annotations on write*Snapshot() methods to generate savepoints
* TODO Note: You should generate the savepoint based on the release branch instead of the master.
*/
private final MigrationVersion flinkGenerateSavepointVersion = null;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ public static Collection<MigrationVersion> parameters () {
/**
* TODO change this to the corresponding savepoint version to be written (e.g. {@link MigrationVersion#v1_3} for 1.3)
* TODO and remove all @Ignore annotations on write*Snapshot() methods to generate savepoints
* TODO Note: You should generate the savepoint based on the release branch instead of the master.
*/
private final MigrationVersion flinkGenerateSavepointVersion = null;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ public static Collection<Tuple2<MigrationVersion, String>> parameters () {
* TODO to generate savepoints for a specific Flink version / backend type,
* TODO change these values accordingly, e.g. to generate for 1.3 with RocksDB,
* TODO set as (MigrationVersion.v1_3, StateBackendLoader.ROCKSDB_STATE_BACKEND_NAME)
* TODO Note: You should generate the savepoint based on the release branch instead of the master.
*/
private final MigrationVersion flinkGenerateSavepointVersion = MigrationVersion.v1_4;
private final String flinkGenerateSavepointBackendType = StateBackendLoader.ROCKSDB_STATE_BACKEND_NAME;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ public enum ExecutionMode {
}

// TODO change this to PERFORM_SAVEPOINT to regenerate binary savepoints
// TODO Note: You should generate the savepoint based on the release branch instead of the master.
private final ExecutionMode executionMode = ExecutionMode.VERIFY_SAVEPOINT;

@Parameterized.Parameters(name = "Migrate Savepoint / Backend: {0}")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public class StatefulJobWBroadcastStateMigrationITCase extends SavepointMigratio
private static final int NUM_SOURCE_ELEMENTS = 4;

// TODO change this to PERFORM_SAVEPOINT to regenerate binary savepoints
// TODO Note: You should generate the savepoint based on the release branch instead of the master.
private final StatefulJobSavepointMigrationITCase.ExecutionMode executionMode =
StatefulJobSavepointMigrationITCase.ExecutionMode.VERIFY_SAVEPOINT;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public enum ExecutionMode {
}

// TODO change this to PERFORM_SAVEPOINT to regenerate binary savepoints
// TODO Note: You should generate the savepoint based on the release branch instead of the master.
private final ExecutionMode executionMode = ExecutionMode.VERIFY_SAVEPOINT;

@Parameterized.Parameters(name = "Migrate Savepoint / Backend: {0}")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ object StatefulJobSavepointMigrationITCase {
// TODO to generate savepoints for a specific Flink version / backend type,
// TODO change these values accordingly, e.g. to generate for 1.3 with RocksDB,
// TODO set as (MigrationVersion.v1_3, StateBackendLoader.ROCKSDB_STATE_BACKEND_NAME)
// TODO Note: You should generate the savepoint based on the release branch instead of the master.
val GENERATE_SAVEPOINT_VER: MigrationVersion = MigrationVersion.v1_4
val GENERATE_SAVEPOINT_BACKEND_TYPE: String = StateBackendLoader.ROCKSDB_STATE_BACKEND_NAME

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ object StatefulJobWBroadcastStateMigrationITCase {
// TODO to generate savepoints for a specific Flink version / backend type,
// TODO change these values accordingly, e.g. to generate for 1.3 with RocksDB,
// TODO set as (MigrationVersion.v1_3, StateBackendLoader.ROCKSDB_STATE_BACKEND_NAME)
// TODO Note: You should generate the savepoint based on the release branch instead of the master.
val GENERATE_SAVEPOINT_VER: MigrationVersion = MigrationVersion.v1_7
val GENERATE_SAVEPOINT_BACKEND_TYPE: String = StateBackendLoader.MEMORY_STATE_BACKEND_NAME

Expand Down

0 comments on commit 6650d74

Please sign in to comment.