Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on master (and set Unitful version number to 1.4.1) #380

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

sostock
Copy link
Collaborator

@sostock sostock commented Sep 14, 2020

This adapts the tests to the new type parameter printing (JuliaLang/julia#37085) and changes the version number to a new patch release (1.4.1).

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #380 into master will increase coverage by 2.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   80.33%   83.33%   +2.99%     
==========================================
  Files          15       15              
  Lines        1195     1284      +89     
==========================================
+ Hits          960     1070     +110     
+ Misses        235      214      -21     
Impacted Files Coverage Δ
src/Unitful.jl 100.00% <0.00%> (ø)
src/quantities.jl 94.11% <0.00%> (+0.52%) ⬆️
src/user.jl 95.73% <0.00%> (+0.69%) ⬆️
src/fastmath.jl 84.50% <0.00%> (+1.96%) ⬆️
src/utils.jl 95.34% <0.00%> (+2.32%) ⬆️
src/types.jl 92.00% <0.00%> (+2.63%) ⬆️
src/conversion.jl 86.56% <0.00%> (+2.69%) ⬆️
src/promotion.jl 43.47% <0.00%> (+3.47%) ⬆️
src/units.jl 86.48% <0.00%> (+3.60%) ⬆️
src/logarithm.jl 70.00% <0.00%> (+3.92%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ceb37...de4cbf1. Read the comment docs.

@sostock sostock changed the title Fix tests on master (and release 1.4.1) Fix tests on master (and set Unitful version number to 1.4.1) Sep 14, 2020
@giordano giordano merged commit 2a8d554 into PainterQubits:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants