Allow nil arguments for function #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicpatel
force-pushed
the
fix-allowing-nil-as-argument
branch
from
e9af766
to
07ad5c3
Compare
It uses reflect value for interface when argument is resolved as nil.
vicpatel
force-pushed
the
fix-allowing-nil-as-argument
branch
from
07ad5c3
to
30e2ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows
nilas an argument for function, so this chance will use reflect value for the interface when argument is resolved asnilinstead of throwing an error.This is necessary for some scenarios where
nilis expected as an argument butcreateCallArgumentsthrows an error for thenilargument hence the underlying referenced function is resulting in an error. eg.IsNil(i interface {}) bool.This will solve this problem but of course, Is there any workaround for this?
Please take a look.