Add DecimalArithmetic language #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes addition of parsing and operations against decimal.Decimal. Includes tests and benchmarks. DecimalArithmetic is not included in `Full` as it overrides float.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will merge in the handling of DecimalArithmetic.
Decimal (base10 numbers) arithmetic is different to floating point (base2 numbers) arithmetic, and in use cases that involve money, it's imperative that the user is given the option to have any arithmetic calculations made using fixed-point decimal numbers rather than floating point.
DecimalArithmeticis added and used strictly as an optional use case (not added to thefull()language set). It is not used unless one specifies its use.Use can be specified by calling the
DecimalArithmeticlanguage directly and evaluation expressions against that language.DecimalArithmeticoverrides the default handling forscanner.Intandscanner.Floatto useparseDecimaland then all arithmetic is run against thedecimal.Decimalfrom the widely used shopspring/decimal repository.Tests and Benchmark Tests have been added.
This pull request fixes #70.