Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions inside expression are evaluated in coroutine and on panic are not recovered thus crashing whole application #79

Closed
aldas opened this issue Mar 9, 2022 · 0 comments · Fixed by #85

Comments

@aldas
Copy link

aldas commented Mar 9, 2022

functions inside expressions are evaluated in coroutine and on panic are not recovered thus crashing whole application. I think there should be somekind of recover as when coroutine ends with not recovered panic the whole application gets shutdown by go runtime.

go func() {

and
go func() {

note: why it is done in coroutine? from timeout or context cancellation perspective this makes little sense because if there is endless loop returning from expression that "timeouted" makes little difference because that endless coroutine still works on background.

@aldas aldas changed the title expression are evaluated in coroutine and on panic are not recovered thus crashing whole application functions inside expression are evaluated in coroutine and on panic are not recovered thus crashing whole application Mar 9, 2022
Yangruipis pushed a commit to Yangruipis/gval that referenced this issue Aug 5, 2022
Yangruipis pushed a commit to Yangruipis/gval that referenced this issue Aug 5, 2022
generikvault added a commit that referenced this issue Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant