-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add MobileSAM #3349
[Feature] Add MobileSAM #3349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 需要验证加载相同参数情况下,前向推理随机数输入和图片输入均和mobileSAM对齐。
- 另外模型参数可以给我链接上传。
- codestyle 没过,需要安装pre-commit:https://github.com/PaddlePaddle/PaddleSeg/blob/develop/docs/pr/pr/pr.md#4-use-pre-commit-hook; pre-commit run --all-files
contrib/SegmentAnything/segment_anything/modeling/tiny_vit_sam.py
Outdated
Show resolved
Hide resolved
如果修改好可以re-request review。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码验证完成,需要修改一些code style,并替换vit-t为下面的模型链接:https://paddleseg.bj.bcebos.com/dygraph/paddlesegAnything/vit_t/model.pdparam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
很棒,但是还有一些小改动,其他没有问题。
另外code style还是没有通过,也许需要到paddleseg根目录下进行code style的检查。
pre-commit run --files contrib/SegmentAnything/*
contrib/SegmentAnything/segment_anything/modeling/tiny_vit_sam.py
Outdated
Show resolved
Hide resolved
contrib/SegmentAnything/segment_anything/modeling/tiny_vit_sam.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
Models
Description
Add MobileSAM
fix #3346
Vit-T 预测结果如下: