Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace GPL licensed components #6585

Merged
merged 1 commit into from
Jul 4, 2022
Merged

replace GPL licensed components #6585

merged 1 commit into from
Jul 4, 2022

Conversation

maxbachmann
Copy link

@maxbachmann maxbachmann commented Jun 14, 2022

This PR replaces GPL licensed libraries for string comparisions with rapidfuzz which has the following advantages:

  • MIT license compatible with the Apache License of PaddleOCR, which is not the case for the currently used GPL licensed libraries
  • interface provides a normalized distance, which makes it possible to simplify the code here
  • faster implementation than both python-Levenshtein and distance
  • actively maintained, which is not the case both for python-Levenshtein and distance
  • provides wheels for all common platforms, which simplifies the installation for users

@paddle-bot-old
Copy link

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@WenmuZhou WenmuZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GT-ZhangAcer
Copy link
Member

GT-ZhangAcer commented Jun 27, 2022

Very good change. Compared with the original scheme, the WHL package is provided to avoid some user environment problems.

@Evezerest Evezerest merged commit 4c29b07 into PaddlePaddle:release/2.5 Jul 4, 2022
Evezerest added a commit to Evezerest/PaddleOCR that referenced this pull request Aug 20, 2022
littletomatodonkey pushed a commit that referenced this pull request Aug 21, 2022
* Merge pull request #6824 from ChenNima/release/2.5-kie-save-res

[kie]add write_kie_result to kie infer tool

* Merge pull request #6677 from TonyJiangWJ/release/2.5

修复内存泄露问题

* Update native.cpp (#6650)

fix issue 6640

* Merge pull request #6625 from ynjang/ynjang

update sorted_boxes

* fix DeprecationWarning, (#6604)

DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead

* Merge pull request #6585 from maxbachmann/release/2.5

replace GPL licensed components

* Merge pull request #6575 from Eling486/release/2.5

update win doc

* Merge pull request #6477 from MikoyChinese/fix-copy-paste

Fix copy_paste no texts augment.

* Merge pull request #6361 from mohamadmansourX/patch-9

Update README_en.md

Co-authored-by: Double_V <[email protected]>
Co-authored-by: shawn <[email protected]>
Co-authored-by: paopjian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants