Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改get_logger使用的默认name为paddle #65271

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ireson96
Copy link

@ireson96 ireson96 commented Jun 18, 2024

PR Category

User Experience

PR Types

Improvements

Description

Change the default name used by logging.getLogger

修改调用logging.getLogger时使用的默认name,参考logging库,使用“root”作为name则相当于所有logger都会生效 会导致引用后上层使用logger重复调用(具体可参考PaddlePaddle/PaddleOCR#13122)

ps

logging库的实现:
image
image

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ireson96 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

paddle-bot bot commented Jun 18, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 18, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 24, 2024
@luotao1
Copy link
Contributor

luotao1 commented Jun 24, 2024

@GreatV 请审核

@GreatV
Copy link
Contributor

GreatV commented Jun 25, 2024

另外 cla 要签一下

Copy link
Contributor

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

失败的流水线要rerun一下

@ireson96 ireson96 changed the title 修改get_logger使用的默认name 修改get_logger使用的默认name为paddle Jun 30, 2024
Copy link

paddle-ci-bot bot commented Jul 3, 2024

Sorry to inform you that 9e114c3's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants