Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #28 license substitution in files #57

Merged
merged 4 commits into from
Jun 7, 2013
Merged

issue #28 license substitution in files #57

merged 4 commits into from
Jun 7, 2013

Conversation

eux
Copy link
Member

@eux eux commented Jun 6, 2013

No description provided.

@giorrrgio
Copy link
Member

👍

@leopro
Copy link
Member

leopro commented Jun 6, 2013

👍
but the author (@liuggio) maybe should be remain as proposed in #28

@eux
Copy link
Member Author

eux commented Jun 7, 2013

@liuggio is the author of all the classes? I think that who made the classes or contributed can insert or update the authorship.

@liuggio
Copy link
Member

liuggio commented Jun 7, 2013

We can’t automatically merge this pull request.

@eux
Copy link
Member Author

eux commented Jun 7, 2013

I pulled and solved the conflicts with the PR made by @garak.
I added functional tests for stats. What is a poser without well tested stats? :)

@@ -2,7 +2,7 @@ imports:
- { resource: config.yml }

services:
stats_listener:
stats_persister:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you agree with this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@liuggio
Copy link
Member

liuggio commented Jun 7, 2013

when we'll close this, we'll be officially in the RC.

leopro added a commit that referenced this pull request Jun 7, 2013
issue #28 license substitution in files
@leopro leopro merged commit 5f8d3c8 into PUGX:master Jun 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants