Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update fstring implementaion for sqlite dialect #1638

Merged
merged 3 commits into from
Jan 29, 2023
Merged

fix: update fstring implementaion for sqlite dialect #1638

merged 3 commits into from
Jan 29, 2023

Conversation

bcho
Copy link
Contributor

@bcho bcho commented Jan 28, 2023

This pull request fixes #1637 by adding a new option has_concat_function in the DialectHandler trait, then falling back to use || operator when it's not available.

I have tested with unit test and local build.

max-sixty
max-sixty approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you @bcho !

If you're up for adding a changelog entry please feel free! We'll merge shortly either way!

@bcho
Copy link
Contributor Author

bcho commented Jan 28, 2023

I am good with current change, please feel free to merge it and add the changelog.

@max-sixty max-sixty merged commit 19e4b2a into PRQL:main Jan 29, 2023
@bcho bcho deleted the fix/sqlite-concat branch February 1, 2023 14:07
@max-sixty max-sixty mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect fstring implementation for sqlite dialect
2 participants
@bcho @max-sixty