Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing delaunay and voronoi generators #2664

Merged
merged 16 commits into from
Jan 19, 2023
Merged

Conversation

jgostick
Copy link
Member

@jgostick jgostick commented Jan 5, 2023

Fixes #2646
Fixes #2635
Closes #1895

@jgostick
Copy link
Member Author

jgostick commented Jan 6, 2023

There is one test failing, which is caused by the Dijkstra algorithm returning something different in V1.10 than in previous versions. I have opened a bug report on the scipy repo.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #2664 (d7d9b5b) into dev (9d2a192) will decrease coverage by 0.1%.
The diff coverage is 83.7%.

Additional details and impacted files
@@           Coverage Diff           @@
##             dev   #2664     +/-   ##
=======================================
- Coverage   90.1%   90.0%   -0.1%     
=======================================
  Files        146     146             
  Lines       8400    8466     +66     
=======================================
+ Hits        7570    7623     +53     
- Misses       830     843     +13     

@jgostick
Copy link
Member Author

Mac builds are failing again, but this seems to be a common thing so I'm going to ignore it for now and merge this.

@jgostick jgostick merged commit ea567cd into dev Jan 19, 2023
@ma-sadeghi ma-sadeghi deleted the fixing_delaunay_generators branch July 6, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant