Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop in ODS Reader #832

Closed
wants to merge 1 commit into from
Closed

Loop in ODS Reader #832

wants to merge 1 commit into from

Conversation

Krakozaber
Copy link
Contributor

Fix loop in listWorksheetInfo()

This is:

- [ +] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Loop in listWorksheetInfo()

@Krakozaber
Loop in ODS Reader
9bd2c08 
Fix loop in listWorksheetInfo()
@PowerKiKi PowerKiKi closed this in 39b573b Jan 2, 2019
@PowerKiKi
Copy link
Member

Could you please let us know what $xml->name was for the element that caused an infinite loop ?

@Krakozaber
Copy link
Contributor Author

Krakozaber commented Jan 2, 2019 •
edited

<text></text>

@PowerKiKi
Copy link
Member

That seems to be an invalid file. While your PR was merged, I'd recommend re-considering the tool you used to create the files in the first place.

@Krakozaber
Copy link
Contributor Author

Krakozaber commented Jan 9, 2019 •
edited

It's libre office 6

guillaume-ro-fr pushed a commit to guillaume-ro-fr/PhpSpreadsheet that referenced this pull request Jun 12, 2019
@Krakozaber @guillaume-ro-fr
Fix infinite loop when reading invalid ODS files
7ca97b3 
According to the spec, https://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1415588_253892949,
a `<table:table-row>` can only ever contains a `<table:table-cell>` or
a `<table:covered-table-cell>`, but it seems that some invalid files in the wild
may contains something else. That would trigger an infinite loop. So instead we
totally ignore the invalid content.

Closes PHPOffice#832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Krakozaber @PowerKiKi