Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fillColor for charts (only xlsx) #158

Closed
wants to merge 8 commits into from
Closed

added fillColor for charts (only xlsx) #158

wants to merge 8 commits into from

Conversation

CrazyBite
Copy link
Contributor

@CrazyBite CrazyBite commented May 16, 2017

@PowerKiKi , I think my develop branch already rebuilded ..

@PowerKiKi
Copy link
Member

It seems there are code style errors. You can fix them automatically with ./vendor/bin/php-cs-fixer fix


/**
* Create a new DataSeriesValues object
>>>>>>> aea557bd70f6e4ac13ca625c342fce26ad544331
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of leftover from a not well resolved conflict should be removed

@CrazyBite
Copy link
Contributor Author

@PowerKiKi already fixed, but it's wrong again ...

@PowerKiKi PowerKiKi mentioned this pull request May 17, 2017
@PowerKiKi
Copy link
Member

It seems you used a different PHP-Cs-Fixer with a different configuration than the one shipped with this project (.php_cs.dist). I think a3355c2 should be reverted, and PHP-Cs-Fixer should be used with PhpSpreadsheet custom configuration, meaning that the changes should be minimal.

@CrazyBite
Copy link
Contributor Author

I hate travis :C

@PowerKiKi
Copy link
Member

To avoid waiting on Travis every time, you can reproduce the check done by Travis locally with the following lines (saved in check.sh):

#!/bin/bash
set -xe

./vendor/bin/php-cs-fixer fix --dry-run --diff
./vendor/bin/phpcs --report-width=200 --report-summary  --report-full samples/ src/ tests/ --standard=PSR2 -n
./vendor/bin/phpunit

@PowerKiKi PowerKiKi closed this in e6c95bf Sep 7, 2017
@PowerKiKi
Copy link
Member

I fixed a few stuff and merged it, thanks.

Next time we'll have to cover new code with unit tests though...

krzysztofruszczynski added a commit to krzysztofruszczynski/PhpSpreadsheet that referenced this pull request Nov 9, 2018
PowerKiKi pushed a commit that referenced this pull request Dec 10, 2018
This is an follow-up for #158

Fixes #768
guillaume-ro-fr pushed a commit to guillaume-ro-fr/PhpSpreadsheet that referenced this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants