Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger regex; see #664 #714

Closed
wants to merge 2 commits into from
Closed

Stronger regex; see #664 #714

wants to merge 2 commits into from

Conversation

btry
Copy link

@btry btry commented Jan 28, 2016

Please see the above mentioned issue.

This change works for me and is still working with sample_23

EDIT : this may / should also be applied to replaceBlock()

@juch
Copy link

juch commented Dec 1, 2016

I use this one :

'/'. // start of block '(<w:p(?:(?!<w:p)[\s\S])*\$\{'.$blockname.'\}<\/w:.*?p>)'. // content of block '(.*?)'. // end of block '(<w:p(?:(?!<w:p)[\s\S])*\$\{\/'.$blockname.'\}<\/w:.*?p>)'. // end of the string '.*'. '/ism'

@troosan
Copy link
Contributor

troosan commented Dec 26, 2018

this issue does not seem to apply anymore, wrote unit test for it TemplateProcessorTest::testCloneBlock
Feel free to reopen/create new PR if needed

@troosan troosan closed this Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants