Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to travis php version #665

Closed

Conversation

michaelachrisco
Copy link

Small code coverage on section footers.

Small code coverage on section footers
@michaelachrisco
Copy link
Author

Looks like String is a protected word in php 7.0. Ill add in a patch (String -> CommonString).

michaelachrisco and others added 2 commits November 22, 2015 12:18
  - Renamed PHP Word String to Common String
  - Add back in deprecated package
@michaelachrisco
Copy link
Author

Two bugs:

  • Methods with the same name as their class will not be constructors in a future version of PHP; PclZip has a deprecated constructor
  • Methods with the same name as their class will not be constructors in a future version of PHP; mPDF has a deprecated constructor

Looks like either these packages need to be updated or fixed of PHP 7 errors. Down the rabbit hole I go.

@Haringat
Copy link

You should revert 72927e3.
The package tecnick.com/tcpdf is abandoned and replaced by tecnickcom/tcpdf so the former dependency list was correct.

@michaelachrisco
Copy link
Author

@Haringat Ill take a stab at this later today. I have a feeling that it wont be as simple as requiring the correct library and off we go. I have no idea if the two libraries can work with PHP 7.0. tecnickcom/tcpdf does not have a travis build by the look of it

@michaelachrisco
Copy link
Author

Small update: I believe I am going to let 7.0 fail at the moment (unless someone else has a better option?), and make the test pass. I'll go down the rabbit hole on some of the dependencies to fix the 7.0 issue on their side and then push to this branch.

@ghost ghost added the Change Request label Jan 23, 2016
@ghost ghost added this to the 0.13.0 milestone Jan 23, 2016
@ghost ghost self-assigned this Jan 23, 2016
ghost pushed a commit that referenced this pull request Jan 23, 2016
ghost pushed a commit that referenced this pull request Jan 23, 2016
@ghost ghost removed this from the 0.13.0 milestone Jan 23, 2016
@ghost
Copy link

ghost commented Jan 23, 2016

Partially duplicate of #658.

As regards coverage. I made couple experiments and found that @codeCoverageIgnore annotation sometimes has no effect. I have no idea why.

I think we should consider upgrading PHPUnit in the future. We use very old one, and it may have some bugs. Thanks for pointing this out.

@ghost ghost closed this Jan 23, 2016
ghost pushed a commit that referenced this pull request Jan 23, 2016
ghost pushed a commit that referenced this pull request Jan 23, 2016
@michaelachrisco
Copy link
Author

Thanks @RomanSyroeshko I was stuck for a while on some of the tests and why they were not passing. Going into the dependent repos was a rabbit hole. Glad to see someone working on 7.0 coverage.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants