-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to travis php version #665
Conversation
Small code coverage on section footers
Looks like String is a protected word in php 7.0. Ill add in a patch (String -> CommonString). |
6c60ee5
to
5ae8436
Compare
- Renamed PHP Word String to Common String
- Add back in deprecated package
5ae8436
to
72928e3
Compare
Two bugs:
Looks like either these packages need to be updated or fixed of PHP 7 errors. Down the rabbit hole I go. |
You should revert 72927e3. |
@Haringat Ill take a stab at this later today. I have a feeling that it wont be as simple as requiring the correct library and off we go. I have no idea if the two libraries can work with PHP 7.0. tecnickcom/tcpdf does not have a travis build by the look of it |
Small update: I believe I am going to let 7.0 fail at the moment (unless someone else has a better option?), and make the test pass. I'll go down the rabbit hole on some of the dependencies to fix the 7.0 issue on their side and then push to this branch. |
Partially duplicate of #658. As regards coverage. I made couple experiments and found that I think we should consider upgrading PHPUnit in the future. We use very old one, and it may have some bugs. Thanks for pointing this out. |
Thanks @RomanSyroeshko I was stuck for a while on some of the tests and why they were not passing. Going into the dependent repos was a rabbit hole. Glad to see someone working on 7.0 coverage. |
Small code coverage on section footers.